http3: sniff Content-Type when flushing the ResponseWriter #4412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When caddy log is enabled, it can be observed
Content-Type
sniffing no longer works for http3, but works for h1/2. This is caused because when logging is enabled, caddy wraps all response writers withresponseRecorder
which will callWriteHeader
first.Stdlib will try set
Content-Type
header in the same logic, for http1,*chunkWriter
is wrapped by*response
to write the actual data. http2 will set this header in the same way.Because this header is set once, it won't be overwritten automatically