http3: expose an OpenStream method on the RoundTripper #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
changed the title
marten-seemann
force-pushed
the
roundtripper-open-stream
branch
2 times, most recently
from
bc715af
to
f19b6e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4409 +/- ##
=========================================
Coverage ? 84.86%
=========================================
Files ? 152
Lines ? 14396
Branches ? 0
=========================================
Hits ? 12216
Misses ? 1683
Partials ? 497 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
roundtripper-open-stream
branch
3 times, most recently
from
dac6754
to
8df1332
Compare
The stream exposes two methods required for doing an HTTP request: SendRequestHeader and ReadResponse. This can be used by applications that wish to use the stream for non-HTTP content afterwards. This will lead to a simplification in the API we need to expose for WebTransport, and will make it easier to send HTTP Datagrams associated with this stream.
marten-seemann
force-pushed
the
roundtripper-open-stream
branch
from
8df1332
to
125b702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3522.
The stream exposes two methods required for doing an HTTP request:
SendRequestHeaderandReadResponse. This can be used by applications that wish to use the stream for non-HTTP content afterwards. This will lead to a simplification in the API we need to expose for WebTransport, and will make it easier to send HTTP Datagrams associated with this stream.