Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: reference the correct RFCs in doc comments #4399

Merged
merged 1 commit into from
Apr 1, 2024
Merged

http3: reference the correct RFCs in doc comments #4399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
http3: reference the correct RFCs in doc comments
  • Loading branch information
@marten-seemann
marten-seemann committed Apr 1, 2024
commit dc2f857ba3f5c32cbb099464abc959f969fb9316
2 changes: 1 addition & 1 deletion http3/roundtrip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ type RoundTripper struct {
EnableDatagrams bool

// Additional HTTP/3 settings.
// It is invalid to specify any settings defined by the HTTP/3 draft and the datagram draft.
// It is invalid to specify any settings defined by RFC 9114 (HTTP/3) and RFC 9297 (HTTP Datagrams).
AdditionalSettings map[uint64]uint64

// When set, this callback is called for the first unknown frame parsed on a bidirectional stream.
Expand Down
5 changes: 2 additions & 3 deletions http3/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,8 @@ type Server struct {
// http.NotFound.
Handler http.Handler

// EnableDatagrams enables support for HTTP/3 datagrams.
// EnableDatagrams enables support for HTTP/3 datagrams (RFC 9297).
// If set to true, QUICConfig.EnableDatagram will be set.
// See https://datatracker.ietf.org/doc/html/rfc9297.
EnableDatagrams bool

// MaxHeaderBytes controls the maximum number of bytes the server will
Expand All @@ -193,7 +192,7 @@ type Server struct {
MaxHeaderBytes int

// AdditionalSettings specifies additional HTTP/3 settings.
// It is invalid to specify any settings defined by the HTTP/3 draft and the datagram draft.
// It is invalid to specify any settings defined by RFC 9114 (HTTP/3) and RFC 9297 (HTTP Datagrams).
AdditionalSettings map[uint64]uint64

// StreamHijacker, when set, is called for the first unknown frame parsed on a bidirectional stream.
Expand Down
Loading