http3: don't modify any fields of the http.Request when doing 0-RTT #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4379 +/- ##
==========================================
+ Coverage 84.86% 84.87% +0.01%
==========================================
Files 151 151
Lines 14337 14343 +6
==========================================
+ Hits 12167 12173 +6
Misses 1670 1670
Partials 500 500 ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Mar 22, 2024
|
It should be possible to issue the same request twice. |
marten-seemann
force-pushed
the
http3-dont-modify-0rtt-requests
branch
from
0d32030
to
bd1f368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4378.