quicvarint: use int instead of internal protocol.ByteCount type #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Mar 9, 2024
| - "**/github.com/quic-go/quic-go/quicvarint/*" | ||
| - "!$test" | ||
| allow: | ||
| - $gostd |
There was a problem hiding this comment.
Adding a validation here. This package shouldn't need to use any packages outside of the standard library.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4356 +/- ##
==========================================
- Coverage 84.81% 84.80% -0.01%
==========================================
Files 150 150
Lines 14287 14287
==========================================
- Hits 12117 12116 -1
- Misses 1671 1672 +1
Partials 499 499 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if
intoruint64would be better here.