unmap IPv4-mapped IPv6 addresses #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4309 +/- ##
==========================================
+ Coverage 84.13% 84.15% +0.02%
==========================================
Files 150 150
Lines 15368 15368
==========================================
+ Hits 12929 12932 +3
+ Misses 1940 1937 -3
Partials 499 499 ☔ View full report in Codecov by Sentry. |
|
Hi @thijsvandien, what's the status of this PR (and the other one)? Should we get this landed some time soon? |
|
Both are ready to be merged in my opinion, apart from the failing check that I cannot explain. Which one(s) you pick is up to your discretion, since it's a design choice where to do the conversion from IPv4-mapped IPv6 to IPv4. |
marten-seemann
approved these changes
Mar 5, 2024
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4308.
As an alternative or addition to #4308 (issues #4304 and #4105). Perhaps this can better be dealt with at the boundary.