qlog: disentangle the ConnectionTracer from the qlog writer #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4300 +/- ##
==========================================
+ Coverage 84.10% 84.13% +0.03%
==========================================
Files 149 150 +1
Lines 15345 15351 +6
==========================================
+ Hits 12905 12915 +10
+ Misses 1941 1938 -3
+ Partials 499 498 -1 ☔ View full report in Codecov by Sentry. |
marten-seemann
force-pushed
the
qlog-writer
branch
from
d83c51b
to
9010a15
Compare
sukunrt
approved these changes
Feb 2, 2024
The qlog writer simply records events, puts them into a channel, and consumes these events in a separate Go routine (by serializing them). The ConnectionTracer is the one generating those events.
marten-seemann
force-pushed
the
qlog-writer
branch
from
9010a15
to
94c9205
Compare
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
…4300) The qlog writer simply records events, puts them into a channel, and consumes these events in a separate Go routine (by serializing them). The ConnectionTracer is the one generating those events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qlog writer simply records events, puts them into a channel, and consumes these events in a separate Go routine (by serializing them).
The
ConnectionTraceris the one generating those events.This will make it possible to export qlog using a
Tracer(i.e. for events that don't belong to any connections), and it paves the way for serializing qlog events outside of the quic package (see #4124).