Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ackhandler: don't delay ACKs for Initial and Handshake packets #4288

Merged
merged 2 commits into from
Feb 1, 2024
Merged

ackhandler: don't delay ACKs for Initial and Handshake packets #4288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a217723
ackhandler: don't delay ACKs for Initial and Handshake packets
marten-seemann Jan 30, 2024
93f679e
ackhandler: embed the receivedPacketHistory
marten-seemann Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ackhandler: embed the receivedPacketHistory
  • Loading branch information
@marten-seemann
marten-seemann committed Jan 30, 2024
commit 93f679ec4546b481c98ae3735da3a3b23fc349ea
4 changes: 2 additions & 2 deletions internal/ackhandler/received_packet_tracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ import (
type receivedPacketTracker struct {
ect0, ect1, ecnce uint64

packetHistory *receivedPacketHistory
packetHistory receivedPacketHistory

lastAck *wire.AckFrame
hasNewAck bool // true as soon as we received an ack-eliciting new packet
}

func newReceivedPacketTracker() *receivedPacketTracker {
return &receivedPacketTracker{packetHistory: newReceivedPacketHistory()}
return &receivedPacketTracker{packetHistory: *newReceivedPacketHistory()}
}

func (h *receivedPacketTracker) ReceivedPacket(pn protocol.PacketNumber, ecn protocol.ECN, rcvTime time.Time, ackEliciting bool) error {
Expand Down
Loading