Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire: optimize generation of Version Negotiation packets #4278

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jan 29, 2024

name                                old time/op    new time/op    delta
ComposeVersionNegotiationPacket-16     900ns ± 2%     317ns ± 3%  -64.74%  (p=0.000 n=10+10)

name                                old alloc/op   new alloc/op   delta
ComposeVersionNegotiationPacket-16      120B ± 0%       64B ± 0%  -46.67%  (p=0.000 n=10+10)

name                                old allocs/op  new allocs/op  delta
ComposeVersionNegotiationPacket-16      6.00 ± 0%      2.00 ± 0%  -66.67%  (p=0.000 n=10+10)

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbaa941) 84.03% compared to head (9502db6) 84.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4278      +/-   ##
==========================================
+ Coverage   84.03%   84.19%   +0.15%     
==========================================
  Files         146      149       +3     
  Lines       15081    15397     +316     
==========================================
+ Hits        12673    12962     +289     
- Misses       1924     1937      +13     
- Partials      484      498      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the optimize-compose-vnp branch 2 times, most recently from 38bae47 to ea290e5 Compare January 30, 2024 02:42
@marten-seemann marten-seemann merged commit 0582e93 into master Feb 1, 2024
34 checks passed
@marten-seemann marten-seemann deleted the optimize-compose-vnp branch February 1, 2024 23:02
mgjeong pushed a commit to mgjeong/quic-go that referenced this pull request Feb 13, 2024
* wire: optimize generation of Version Negotiation packets

* protocol: optimize adding greased version numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant