don't enqueue stream when receiving reordered MAX_STREAM_DATA frames #4269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4269 +/- ##
==========================================
+ Coverage 84.09% 84.10% +0.02%
==========================================
Files 150 150
Lines 15421 15425 +4
==========================================
+ Hits 12967 12973 +6
+ Misses 1952 1950 -2
Partials 502 502 ☔ View full report in Codecov by Sentry. |
marten-seemann
changed the title
sukunrt
approved these changes
Feb 3, 2024
marten-seemann
deleted the
dont-queue-stream-on-reordered-max-stream-data
branch
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor optimization. Not sure it matters at all, but it seemed easy enough.