handshake: unexport Set{Read,Write}Key methods on the cryptoSetup #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change expected. These methods were exported since they were passed to the old qtls API.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4254 +/- ##
==========================================
- Coverage 84.09% 84.07% -0.02%
==========================================
Files 150 150
Lines 15401 15401
==========================================
- Hits 12950 12947 -3
- Misses 1950 1953 +3
Partials 501 501 ☔ View full report in Codecov by Sentry. |
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
…ic-go#4254) No functional change expected. These methods were exported since they were passed to the old qtls API.
mgjeong
pushed a commit
to mgjeong/quic-go
that referenced
this pull request
Feb 13, 2024
…ic-go#4254) No functional change expected. These methods were exported since they were passed to the old qtls API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change expected.
These methods were exported since they were passed to the old qtls API.