remove the RequireAddressValidation callback from the Config

[marten-seemann]

Depends on #4248.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (892851e) 84.08% compared to head (78e43cd) 84.08%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4253      +/-   ##
==========================================
- Coverage   84.08%   84.08%   -0.01%     
==========================================
  Files         150      150              
  Lines       15431    15425       -6     
==========================================
- Hits        12975    12969       -6     
  Misses       1953     1953              
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sukunrt]

This specific change looks good. But I think you need to defer this block that decrements the handshake count: https://github.com/quic-go/quic-go/blob/remove-require-address-validation-callback/server.go#L734-L745

There are a couple of returns just above that block.

[marten-seemann]

This specific change looks good. But I think you need to defer this block that decrements the handshake count: https://github.com/quic-go/quic-go/blob/remove-require-address-validation-callback/server.go#L734-L745

There are a couple of returns just above that block.

Done in #4248.