wire: use netip.AddrPort in the Preferred Address transport parameter #4232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code had the subtle problem that it would
append
the IPv6, assuming that it's a 16 byte byte slice:quic-go/internal/wire/transport_parameters.go
Line 391 in 1083d1f
This assumption is not correct if
PreferredAddress.IPv6
was left at its default value. The encode value of the transport parameter then has an incorrect length.