ackhandler: refactor ACK queueing logic #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
refactor-ack-queueing-logic
branch
from
ce03243
to
3c17c09
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4225 +/- ##
==========================================
+ Coverage 83.97% 84.53% +0.55%
==========================================
Files 149 149
Lines 15419 15654 +235
==========================================
+ Hits 12948 13232 +284
+ Misses 1972 1930 -42
+ Partials 499 492 -7 ☔ View full report in Codecov by Sentry. |
Once an ACK has been queued, there's no need to check futher conditions that would lead to queueing of an ACK.
marten-seemann
force-pushed
the
refactor-ack-queueing-logic
branch
from
3c17c09
to
d85eef3
Compare
marten-seemann
commented
Jan 4, 2024
| @@ -1269,7 +1269,6 @@ var _ = Describe("Connection", func() { | |||
| sph.EXPECT().ECNMode(true).AnyTimes() | |||
| runConn() | |||
| packer.EXPECT().AppendPacket(gomock.Any(), gomock.Any(), conn.version).Return(shortHeaderPacket{}, errNothingToPack).AnyTimes() | |||
| conn.receivedPacketHandler.ReceivedPacket(0x035e, protocol.ECNNon, protocol.Encryption1RTT, time.Now(), true) | |||
There was a problem hiding this comment.
I don't understand what the purpose of this call was. And it now causes a race condition when accessing the ackAlarm field.
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
Once an ACK has been queued, there's no need to check futher conditions that would lead to queueing of an ACK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once an ACK has been queued, there's no need to check futher conditions that would lead to queueing of an ACK.
In preparation for #3995.