Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtls: remove unneeded type alias for the tls.QUICEncryptionLevel #4220

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

marten-seemann
Copy link
Member

Some more cleanup after #4195.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (22411e1) 83.95% compared to head (0ea148f) 83.97%.
Report is 1 commits behind head on master.

Files Patch % Lines
internal/handshake/crypto_setup.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4220      +/-   ##
==========================================
+ Coverage   83.95%   83.97%   +0.02%     
==========================================
  Files         149      149              
  Lines       15405    15405              
==========================================
+ Hits        12933    12936       +3     
+ Misses       1973     1971       -2     
+ Partials      499      498       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marten-seemann marten-seemann merged commit d6e3f32 into master Dec 29, 2023
34 checks passed
@marten-seemann marten-seemann deleted the tls-quic-encryption-level branch December 29, 2023 03:01
nanokatze pushed a commit to nanokatze/quic-go that referenced this pull request Feb 1, 2024
…c-go#4220)

* qtls: remove unneeded type alias for the tls.QUICEncryptionLevel

* handshake: make cryptoSetup.WriteRecord private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants