http3: fix channel size in ListenAndServe #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, partially prevent a goroutine leak on an error from one of the listeners.
marten-seemann
approved these changes
Dec 29, 2023
marten-seemann
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4219 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 149 149
Lines 15405 15405
=======================================
Hits 12933 12933
Misses 1973 1973
Partials 499 499 ☔ View full report in Codecov by Sentry. |
nanokatze
pushed a commit
to nanokatze/quic-go
that referenced
this pull request
Feb 1, 2024
* http3: typo in ListenAndServe docs Also, partially prevent a goroutine leak on an error from one of the listeners. * http3: improve documentation for ListenAndServe --------- Co-authored-by: Marten Seemann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two small issues in the
ListenAndServefunction: