Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: switch to builtin min and max funtions #4218

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

marten-seemann
Copy link
Member

These functions were added in Go 1.21.

These functions were added in Go 1.21.
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (18c591c) 83.98% compared to head (576eb99) 83.99%.

Files Patch % Lines
connection.go 75.00% 1 Missing ⚠️
internal/ackhandler/sent_packet_handler.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4218      +/-   ##
==========================================
+ Coverage   83.98%   83.99%   +0.02%     
==========================================
  Files         149      149              
  Lines       15415    15405      -10     
==========================================
- Hits        12945    12939       -6     
+ Misses       1972     1968       -4     
  Partials      498      498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit 22411e1 into master Dec 28, 2023
34 checks passed
@marten-seemann marten-seemann deleted the builtin-min-max branch December 28, 2023 05:19
wwqgtxx added a commit to MetaCubeX/quic-go that referenced this pull request Jan 20, 2024
nanokatze pushed a commit to nanokatze/quic-go that referenced this pull request Feb 1, 2024
nekohasekai pushed a commit to SagerNet/quic-go that referenced this pull request Feb 10, 2024
nekohasekai pushed a commit to SagerNet/quic-go that referenced this pull request Mar 19, 2024
wwqgtxx added a commit to MetaCubeX/quic-go that referenced this pull request Mar 19, 2024
wwqgtxx added a commit to MetaCubeX/quic-go that referenced this pull request Apr 28, 2024
nekohasekai pushed a commit to SagerNet/quic-go that referenced this pull request Apr 28, 2024
nekohasekai pushed a commit to SagerNet/quic-go that referenced this pull request May 15, 2024
wwqgtxx added a commit to MetaCubeX/quic-go that referenced this pull request May 18, 2024
wwqgtxx added a commit to MetaCubeX/quic-go that referenced this pull request May 20, 2024
nekohasekai pushed a commit to SagerNet/quic-go that referenced this pull request Jun 7, 2024
wwqgtxx added a commit to MetaCubeX/quic-go that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant