Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: improve debug message when determining the listener port fails #4214

Merged
merged 1 commit into from
Dec 19, 2023
Merged

http3: improve debug message when determining the listener port fails #4214

merged 1 commit into from
Dec 19, 2023

Conversation

nanokatze
Copy link
Contributor

Fixes: #4212

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d6bf7e) 83.76% compared to head (9219978) 83.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4214      +/-   ##
==========================================
- Coverage   83.76%   83.74%   -0.02%     
==========================================
  Files         150      150              
  Lines       15476    15477       +1     
==========================================
- Hits        12962    12960       -2     
- Misses       2016     2019       +3     
  Partials      498      498

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marten-seemann
marten-seemann reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead print the Addr().String()?

@nanokatze
Copy link
Contributor Author

That seems like the more useful thing to report, indeed.

marten-seemann
marten-seemann approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nanokatze!

@marten-seemann marten-seemann changed the title http3: report the listener when logging extractPort failure http3: improve debug message when determining the listener port fails Dec 19, 2023
@marten-seemann marten-seemann merged commit d3c5f38 into quic-go:master Dec 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http3: bad Errorf
2 participants
@nanokatze @marten-seemann