qtls: only attempt 0-RTT resumption for 0-RTT enabled session tickets #4183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In specific, these lines would overwrite the
EarlyData
property fromfalse
totrue
, when doing session resumption usingDialEarly
(code from master):quic-go/internal/qtls/client_session_cache.go
Lines 49 to 54 in 2d7ea37
In addition to fixing that, we now also avoid saving the transport parameters into the session ticket for non-0-RTT tickets (code from this PR):
quic-go/internal/handshake/crypto_setup.go
Lines 320 to 324 in 3e984c1