logging: pass the packet number to ConnectionTracer.DroppedPacket #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most cases the packet number is not known when a packet is dropped, but it's useful to log the packet number when dropping a duplicate packet.
marten-seemann
force-pushed
the
log-duplicate-packet-number
branch
from
ff0cad1
to
75f20d5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4171 +/- ##
==========================================
+ Coverage 83.73% 83.79% +0.06%
==========================================
Files 150 150
Lines 15418 15425 +7
==========================================
+ Hits 12910 12925 +15
+ Misses 2010 2003 -7
+ Partials 498 497 -1 ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases the packet number is not known when a packet is dropped, but it's useful to log the packet number when dropping a duplicate packet.
I noticed this when looking at the qlogs in #4169.