send large max_datagram_frame size, introduce a DatagramTooLargeError error

[chungthuang]

The size can be overwritten to a lower value for testing. This implements the suggestion from #3300 (comment).

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[marten-seemann]

You'll need to sign the CLA as well.

[chungthuang]

Hi @marten-seemann, thanks for reviewing. Do you have other feedback for this PR?

[marten-seemann]

The size can be overwritten to a lower value for testing.

Do you want to add a test case?

[chungthuang]

The size can be overwritten to a lower value for testing.

Do you want to add a test case?

257b644 adds a test case to make sure peer's max DATAGRAM size is respected.
I think the other case of making sure only DATAGRAM frame that can fit into a packet is sent is already covered in https://github.com/quic-go/quic-go/blob/master/packet_packer_test.go#L594.

[chungthuang]

Hi @marten-seemann, I can squash the commits if you don't have other feedback.

[chungthuang]

Hi @marten-seemann, just want to check if this is good to merge soon?

[marten-seemann]

Sorry for the delay @chungthuang! Tests are failing, can you please take a look?

[chungthuang]

Sorry for the delay @chungthuang! Tests are failing, can you please take a look?

No worries. The tests were failing because internal/wire/transport_parameter_test.go was still using protocol.MaxDatagramFrameSize. This is fixed now.

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a360354) 83.75% compared to head (6de8be9) 83.72%.
Report is 9 commits behind head on master.

Files	Patch %	Lines
connection.go	0.00%	6 Missing ⚠️
errors.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4143      +/-   ##
==========================================
- Coverage   83.75%   83.72%   -0.02%     
==========================================
  Files         150      150              
  Lines       15411    15434      +23     
==========================================
+ Hits        12906    12922      +16     
- Misses       2007     2014       +7     
  Partials      498      498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chungthuang]

Looks like all tests passed, but I don't have permission to merge.

[gr0l0rg]

FINALLY! Thank you @chungthuang for the great work. Hope v0.41 is released soon enough to try it.

[Wasem9926]

[email protected]