don't set the TLS version in the transport #4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already done in the crypto setup.
Codecov Report
@@ Coverage Diff @@
## master #4135 +/- ##
==========================================
+ Coverage 83.73% 83.76% +0.04%
==========================================
Files 150 150
Lines 15411 15410 -1
==========================================
+ Hits 12903 12908 +5
+ Misses 2010 2005 -5
+ Partials 498 497 -1
|
sukunrt
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already done in the crypto setup:
quic-go/internal/handshake/crypto_setup.go
Line 95 in 5311f81