Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the logging.Tracer and logging.ConnectionTracer a struct #4082

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Sep 12, 2023

Fixes #3704.

We’re jumping through a number of hoops here to be able to continue testing using gomock.

@marten-seemann marten-seemann force-pushed the logging-tracer-structs branch 2 times, most recently from 12aeaf5 to b55afdd Compare September 12, 2023 09:13
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4082 (5c5d314) into master (ab1c1be) will increase coverage by 0.08%.
The diff coverage is 83.38%.

@@            Coverage Diff             @@
##           master    #4082      +/-   ##
==========================================
+ Coverage   83.59%   83.67%   +0.08%     
==========================================
  Files         148      149       +1     
  Lines       15227    15341     +114     
==========================================
+ Hits        12728    12836     +108     
- Misses       1999     2004       +5     
- Partials      500      501       +1     
Files Changed Coverage Δ
interface.go 0.00% <ø> (ø)
internal/ackhandler/ackhandler.go 0.00% <ø> (ø)
internal/ackhandler/sent_packet_handler.go 74.50% <0.00%> (-0.58%) ⬇️
internal/handshake/crypto_setup.go 57.73% <0.00%> (ø)
internal/congestion/cubic_sender.go 81.18% <50.00%> (ø)
server.go 76.29% <61.90%> (ø)
logging/connection_tracer.go 89.54% <89.54%> (ø)
connection.go 72.84% <89.74%> (+0.02%) ⬆️
internal/ackhandler/ecn.go 84.47% <90.91%> (ø)
client.go 58.12% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

@marten-seemann marten-seemann changed the title make the logging.Tracer a struct make the logging.Tracer and logging.ConnectionTracer a struct Sep 12, 2023
@marten-seemann marten-seemann marked this pull request as ready for review September 12, 2023 11:36
@marten-seemann marten-seemann force-pushed the logging-tracer-structs branch 3 times, most recently from ad539d9 to 2852aab Compare September 12, 2023 11:46
@marten-seemann marten-seemann merged commit 9b82196 into master Sep 16, 2023
32 checks passed
@marten-seemann marten-seemann deleted the logging-tracer-structs branch September 16, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use a struct, not an interface, for tracers
2 participants