integration tests: fix connection timeout in 0-RTT test #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4060 +/- ##
==========================================
+ Coverage 83.46% 83.48% +0.02%
==========================================
Files 147 147
Lines 14906 14906
==========================================
+ Hits 12440 12443 +3
+ Misses 1970 1967 -3
Partials 496 496 |
|
@tanghaowillow Thanks for the fix! Do you have any idea why this worked before #4013? |
|
Because these tests are introduced in #4013.. I should be have been more careful ( |
marten-seemann
approved these changes
Sep 2, 2023
marten-seemann
changed the title
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0-RTT datagram test the connection/tracer is not closed before fetching the traced packets, which makes it cannot return until the connection becomes timeout.
FIxes #4058