Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GSO control message handling to the oobConn #4056

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Aug 28, 2023

For #3999. For ECN, we'll need to append even more control messages, and the current construction would get too complicated.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4056 (17e9480) into master (2797f85) will increase coverage by 0.62%.
Report is 1 commits behind head on master.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
+ Coverage   83.29%   83.91%   +0.62%     
==========================================
  Files         147      147              
  Lines       14908    15104     +196     
==========================================
+ Hits        12417    12674     +257     
+ Misses       1990     1933      -57     
+ Partials      501      497       -4     
Files Changed Coverage Δ
packet_handler_map.go 84.52% <ø> (ø)
sys_conn.go 77.19% <33.33%> (-2.81%) ⬇️
sys_conn_oob.go 78.19% <66.67%> (+7.70%) ⬆️
transport.go 81.72% <66.67%> (+13.22%) ⬆️
send_conn.go 87.23% <90.00%> (+1.78%) ⬆️
connection.go 72.57% <100.00%> (ø)
send_queue.go 100.00% <100.00%> (ø)
server.go 83.24% <100.00%> (+7.35%) ⬆️

... and 2 files with indirect coverage changes

sys_conn_oob.go Outdated Show resolved Hide resolved
sys_conn_oob.go Show resolved Hide resolved
send_conn.go Show resolved Hide resolved
Copy link
Collaborator

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just this one comment: #4056 (comment)

@marten-seemann marten-seemann merged commit 090e505 into master Aug 31, 2023
33 checks passed
@marten-seemann marten-seemann deleted the refactor-oob branch September 1, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants