Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fail if any Go files contain an ignore directive #4055

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

marten-seemann
Copy link
Member

I almost accidentally committed a test file containing an ignore directive. This wouldn't have been caught by CI, the code would just have been untested.

@marten-seemann marten-seemann force-pushed the ci-find-ignore-go-files branch 3 times, most recently from e20f844 to 31355a6 Compare August 28, 2023 09:22
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4055 (7cfc04d) into master (8f34488) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 7cfc04d differs from pull request most recent head decea66. Consider uploading reports for the commit decea66 to get more accurate results

@@            Coverage Diff             @@
##           master    #4055      +/-   ##
==========================================
+ Coverage   83.27%   83.29%   +0.02%     
==========================================
  Files         147      144       -3     
  Lines       14908    14859      -49     
==========================================
- Hits        12414    12376      -38     
+ Misses       1993     1985       -8     
+ Partials      501      498       -3     

see 7 files with indirect coverage changes

@marten-seemann marten-seemann merged commit 5b25d8b into master Sep 15, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants