Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the DisableVersionNegotiationPackets flag to the Transport #4047

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Aug 26, 2023

Small API cleanup. This flag makes more sense on the Transport than on the Config, since this is not a per-connection option.

It's probably easiest to review this PR without whitespace changes: https://github.com/quic-go/quic-go/pull/4047/files?diff=unified&w=1

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #4047 (180b5e1) into master (e058f56) will increase coverage by 0.04%.
The diff coverage is 94.83%.

@@            Coverage Diff             @@
##           master    #4047      +/-   ##
==========================================
+ Coverage   83.31%   83.35%   +0.04%     
==========================================
  Files         147      147              
  Lines       14908    14907       -1     
==========================================
+ Hits        12420    12425       +5     
+ Misses       1988     1985       -3     
+ Partials      500      497       -3     
Files Changed Coverage Δ
interface.go 0.00% <ø> (ø)
transport.go 72.31% <84.21%> (+3.81%) ⬆️
config.go 100.00% <100.00%> (ø)
server.go 75.93% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

@marten-seemann marten-seemann added this to the v0.39 milestone Aug 31, 2023
@marten-seemann marten-seemann merged commit d7334c1 into master Aug 31, 2023
25 checks passed
@marten-seemann marten-seemann deleted the transport-disable-vnp branch January 25, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants