Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move QUIC_GO_DISABLE_GSO check out of init #4041

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

jfgiorgi
Copy link
Contributor

fix #4040

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isGSOSupported is only called once for every net.PacketConn that we handle, so there's really no point in caching the result.

Change LGTM.

@marten-seemann marten-seemann changed the title move QUIC_GO_DISABLE_GSO test out of init(). move QUIC_GO_DISABLE_GSO check out of init Aug 22, 2023
@marten-seemann
Copy link
Member

@jfgiorgi Would you prefer a patch release, or can this wait until the next regular release?

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #4041 (3401e98) into master (824fd8a) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4041      +/-   ##
==========================================
- Coverage   83.28%   83.26%   -0.02%     
==========================================
  Files         147      147              
  Lines       14902    14898       -4     
==========================================
- Hits        12411    12404       -7     
- Misses       1990     1993       +3     
  Partials      501      501              
Files Changed Coverage Δ
sys_conn_helper_linux.go 75.41% <50.00%> (+3.10%) ⬆️

... and 2 files with indirect coverage changes

@jfgiorgi
Copy link
Contributor Author

@jfgiorgi Would you prefer a patch release, or can this wait until the next regular release?

We can wait.

@marten-seemann marten-seemann merged commit 8d91ad9 into quic-go:master Aug 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't set QUIC_GO_DISABLE_GSO inside Go code.
2 participants