handshake fuzzer: fix TLS handshake sequence #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4033 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 147 147
Lines 14789 14789
=======================================
Hits 12253 12253
Misses 2036 2036
Partials 500 500 |
There were two problems with the existing code: 1. The transport parameters were rejected due to an invalid value for ActiveConnectionIDLimit, causing the handshake to fail. 2. Handshake messages were passed in at the wrong encryption level, leading to consistent handshake failures.
marten-seemann
force-pushed
the
fix-handshake-fuzzer
branch
from
008d957
to
e1e2df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two problems with the existing code:
ActiveConnectionIDLimit, causing the handshake to fail.