Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix invocation of Go routine in example #4019

Merged
merged 1 commit into from
Aug 9, 2023
Merged

README: fix invocation of Go routine in example #4019

merged 1 commit into from
Aug 9, 2023

Conversation

gokpm
Copy link
Contributor

@gokpm gokpm commented Aug 6, 2023

Before

The example goroutine provided in the README.md is not called, it's just defined.

After

Call the goroutine

@google-cla
Copy link

google-cla bot commented Aug 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #4019 (73433fb) into master (aab4d4e) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4019      +/-   ##
==========================================
+ Coverage   82.85%   82.89%   +0.04%     
==========================================
  Files         147      147              
  Lines       14779    14779              
==========================================
+ Hits        12244    12250       +6     
+ Misses       2033     2028       -5     
+ Partials      502      501       -1     

see 2 files with indirect coverage changes

@marten-seemann marten-seemann changed the title [MNT] Call the goroutine, instead of just defining in README.md readme: fix invocation of Go routine in example Aug 6, 2023
@marten-seemann marten-seemann changed the title readme: fix invocation of Go routine in example README: fix invocation of Go routine in example Aug 9, 2023
@marten-seemann marten-seemann merged commit 10d1114 into quic-go:master Aug 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants