Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't set receive buffer if it is already large enough #3407

Merged
merged 1 commit into from
May 12, 2022
Merged

don't set receive buffer if it is already large enough #3407

merged 1 commit into from
May 12, 2022

Conversation

dchaofei
Copy link
Contributor

@dchaofei dchaofei commented May 11, 2022

Fixes #3403.

If the system's receive buffer is large enough, should return immediately.

@marten-seemann marten-seemann changed the title fix set receive buffer don't set receive buffer if it is already large enough May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #3407 (4d7aefe) into master (0a08d62) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
- Coverage   85.36%   85.36%   -0.01%     
==========================================
  Files         135      135              
  Lines        9928     9929       +1     
==========================================
  Hits         8475     8475              
- Misses       1068     1069       +1     
  Partials      385      385              
Impacted Files Coverage Δ
packet_handler_map.go 74.10% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a08d62...4d7aefe. Read the comment docs.

@marten-seemann marten-seemann merged commit b9a77af into quic-go:master May 12, 2022
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setReceiveBuffer question
2 participants