Fix protocol

The default value should be "HTTP/3.0".
quic-go · Jan 23, 2024 · 8d3b667 · 8d3b667
1 parent a2cf43d
commit 8d3b667
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/http3/headers.go b/http3/headers.go
@@ -128,7 +128,8 @@ func requestFromHeaders(headerFields []qpack.HeaderField) (*http.Request, error)
 
  var u *url.URL
  var requestURI string
- var protocol string
+
+ protocol := "HTTP/3.0"
 
  if isConnect {
  u = &url.URL{}
@@ -143,9 +144,10 @@ func requestFromHeaders(headerFields []qpack.HeaderField) (*http.Request, error)
  u.Scheme = hdr.Scheme
  u.Host = hdr.Authority
  requestURI = hdr.Authority
- protocol = hdr.Protocol
+ if hdr.Protocol != "" {
+ protocol = hdr.Protocol
+ }
  } else {
- protocol = "HTTP/3.0"
  u, err = url.ParseRequestURI(hdr.Path)
  if err != nil {
  return nil, fmt.Errorf("invalid content length: %w", err)

diff --git a/http3/headers_test.go b/http3/headers_test.go
@@ -221,6 +221,7 @@ var _ = Describe("Request", func() {
  req, err := requestFromHeaders(headers)
  Expect(err).NotTo(HaveOccurred())
  Expect(req.Method).To(Equal(http.MethodConnect))
+ Expect(req.Proto).To(Equal("HTTP/3.0"))
  Expect(req.RequestURI).To(Equal("quic.clemente.io"))
  })