remove unused getPerspective function from quicConn interface

closed_conn.go

@@ -4,29 +4,26 @@ import (
  "math/bits"
  "net"
 
- "github.com/quic-go/quic-go/internal/protocol"
  "github.com/quic-go/quic-go/internal/utils"
 )
 
 // A closedLocalConn is a connection that we closed locally.
 // When receiving packets for such a connection, we need to retransmit the packet containing the CONNECTION_CLOSE frame,
 // with an exponential backoff.
 type closedLocalConn struct {
- counter uint32
- perspective protocol.Perspective
- logger utils.Logger
+ counter uint32
+ logger utils.Logger
 
  sendPacket func(net.Addr, packetInfo)
 }
 
 var _ packetHandler = &closedLocalConn{}
 
 // newClosedLocalConn creates a new closedLocalConn and runs it.
-func newClosedLocalConn(sendPacket func(net.Addr, packetInfo), pers protocol.Perspective, logger utils.Logger) packetHandler {
+func newClosedLocalConn(sendPacket func(net.Addr, packetInfo), logger utils.Logger) packetHandler {
  return &closedLocalConn{
- sendPacket: sendPacket,
- perspective: pers,
- logger: logger,
+ sendPacket: sendPacket,
+ logger: logger,
  }
 }
 
@@ -43,22 +40,18 @@ func (c *closedLocalConn) handlePacket(p receivedPacket) {
 
 func (c *closedLocalConn) destroy(error) {}
 func (c *closedLocalConn) closeWithTransportError(TransportErrorCode) {}
-func (c *closedLocalConn) getPerspective() protocol.Perspective { return c.perspective }
 
 // A closedRemoteConn is a connection that was closed remotely.
 // For such a connection, we might receive reordered packets that were sent before the CONNECTION_CLOSE.
 // We can just ignore those packets.
-type closedRemoteConn struct {
- perspective protocol.Perspective
-}
+type closedRemoteConn struct{}
 
 var _ packetHandler = &closedRemoteConn{}
 
-func newClosedRemoteConn(pers protocol.Perspective) packetHandler {
- return &closedRemoteConn{perspective: pers}
+func newClosedRemoteConn() packetHandler {
+ return &closedRemoteConn{}
 }
 
 func (c *closedRemoteConn) handlePacket(receivedPacket) {}
 func (c *closedRemoteConn) destroy(error) {}
 func (c *closedRemoteConn) closeWithTransportError(TransportErrorCode) {}
-func (c *closedRemoteConn) getPerspective() protocol.Perspective { return c.perspective }

closed_conn_test.go

@@ -3,26 +3,16 @@ package quic
 import (
  "net"
 
- "github.com/quic-go/quic-go/internal/protocol"
  "github.com/quic-go/quic-go/internal/utils"
 
  . "github.com/onsi/ginkgo/v2"
  . "github.com/onsi/gomega"
 )
 
 var _ = Describe("Closed local connection", func() {
- It("tells its perspective", func() {
- conn := newClosedLocalConn(nil, protocol.PerspectiveClient, utils.DefaultLogger)
- Expect(conn.getPerspective()).To(Equal(protocol.PerspectiveClient))
- })
-
  It("repeats the packet containing the CONNECTION_CLOSE frame", func() {
  written := make(chan net.Addr, 1)
- conn := newClosedLocalConn(
- func(addr net.Addr, _ packetInfo) { written <- addr },
- protocol.PerspectiveClient,
- utils.DefaultLogger,
- )
+ conn := newClosedLocalConn(func(addr net.Addr, _ packetInfo) { written <- addr }, utils.DefaultLogger)
  addr := &net.UDPAddr{IP: net.IPv4(127, 1, 2, 3), Port: 1337}
  for i := 1; i <= 20; i++ {
  conn.handlePacket(receivedPacket{remoteAddr: addr})

packet_handler_map.go

@@ -171,11 +171,10 @@ func (h *packetHandlerMap) ReplaceWithClosed(ids []protocol.ConnectionID, pers p
  func(addr net.Addr, info packetInfo) {
  h.enqueueClosePacket(closePacket{payload: connClosePacket, addr: addr, info: info})
  },
- pers,
  h.logger,
  )
  } else {
- handler = newClosedRemoteConn(pers)
+ handler = newClosedRemoteConn()
  }
 
  h.mutex.Lock()

server.go

@@ -26,7 +26,6 @@ type packetHandler interface {
  handlePacket(receivedPacket)
  destroy(error)
  closeWithTransportError(qerr.TransportErrorCode)
- getPerspective() protocol.Perspective
 }
 
 type packetHandlerManager interface {
@@ -41,7 +40,6 @@ type quicConn interface {
  EarlyConnection
  earlyConnReady() <-chan struct{}
  handlePacket(receivedPacket)
- getPerspective() protocol.Perspective
  run() error
  destroy(error)
  closeWithTransportError(TransportErrorCode)

server_test.go

@@ -1363,7 +1363,6 @@ var _ = Describe("Server", func() {
  Consistently(done).ShouldNot(BeClosed())
 
  // make the go routine return
- conn.EXPECT().getPerspective().MaxTimes(2) // initOnce for every conn ID
  Expect(serv.Close()).To(Succeed())
  Eventually(done).Should(BeClosed())
  })