Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing joins or lookups to reduce query count (PROJQUAY-900) #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing joins or lookups to reduce query count (PROJQUAY-900) #492

wants to merge 1 commit into from

Conversation

josephschorr
Copy link
Contributor

Peewee will invoke an automatic lookup if these are missing, which can
cause excess queries to be made to the database. By adding the missing
join's and model classes into the 'select', we remove these extra calls

Issue: https://issues.redhat.com/browse/PROJQUAY-900

Changelog: None, see the commit

Docs: None

Testing: Any API touched should be tested for correctness:

  • App Registry push/pull and listing
  • Listing build triggers and starting a build via a triggered push
  • Viewing repository notifications
  • Creating and using an OAuth application
  • Looking at the default permissions for an organization and adding a new default permission
  • Inviting someone to a team and having them accept
  • Deleting a repository and verify GC works
  • Deleting a namespace and verify GC works
  • Have a user confirm their email for a new account

Details: See above

@josephschorr josephschorr force-pushed the add-missing-joins branch 2 times, most recently from 23e76e3 to ae6848d Compare July 24, 2020 17:33
Fix missing joins or lookups to reduce query count
480ea3b 
Peewee will invoke an automatic lookup if these are missing, which can
cause excess queries to be made to the database. By adding the missing
join's and model classes into the 'select', we remove these extra calls
@HammerMeetNail HammerMeetNail changed the title Fix missing joins or lookups to reduce query count Fix missing joins or lookups to reduce query count (PROJQUAY-900) Mar 21, 2022
@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@josephschorr @app-sre-bot @alecmerdler