storage(RadosGWStorage): add Region to RadosGWStorage for multi-zone setups (PROJQUAY-7300) #2928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Red Hat/IBM Ceph Storage provides multi-zone setups for on prem and geo-replication of Buckets.
The RadosGWStorage Class in quay does not provide capability to configure
region_name
which is mandator for S3v4 signature in such scenarios.Expectation and change description
The default behavior is not changed as boto3 anyway sets
us-east-1
as default regionThe reason Red Hat/IBM Ceph storage accepts the region is that without Zones in RGW the
default
configuration will accept all signatures in that regards.By extending the RadosGWStorage with the
region_name
parameter we will be able to adjust the region and S3v4 signatures accordingly.The change is minimal inversive as we only need to extend the Class initialization accepted parameters and hand it over to the
connect_kwargs
which are boto3's client/session parameters.The region is called
region_name
which is the reason for the naming schema choosen.Documentation
It is expected that we update the Documentation of the RadosGWStorage class with
region_name
as optional parameter.