Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: batching requests in repository list page (PROJQUAY-6972) #2827

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

bcaton85
Copy link
Contributor

This change batches requests when trying to fetch all repositories the current user has access too. Otherwise the UI will make simultaneous requests equal to the number of organizations, where if the number is great enough it will exhaust the browser resources and cause the page to crash.

Copy link
Contributor

@Sunandadadi Sunandadadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcaton85 bcaton85 merged commit a3ece32 into master Apr 19, 2024
27 checks passed
@jwojnarowicz
Copy link

jwojnarowicz commented Apr 23, 2024

@bcaton85
FWIW, Did you consider displaying the first page immediately?

Right now, if there are lots of repos, the X in 1-25 of X keeps increasing by 100 until it reaches the end and after that the first page is displayed. It can take up to several seconds for lots of repos (over 30s with few thousand repos).

It would be a nice improvement.

@bcaton85
Copy link
Contributor Author

@jwojnarowicz I agree, I created a ticket to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants