Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mongodb test #726

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

loicmathieu
Copy link
Contributor

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@loicmathieu loicmathieu changed the base branch from master to development December 11, 2020 10:10
@loicmathieu
Copy link
Contributor Author

/cc @geoand

Fixes the current CI issue for MongoDB with Panache

@geoand
Copy link
Collaborator

geoand commented Dec 11, 2020

Thanks!

@geoand geoand merged commit 48a9642 into quarkusio:development Dec 11, 2020
@rsvoboda
Copy link
Member

@loicmathieu what change in Quarkus master caused this change? I was just looking into mongodb-panache-quickstart fail.

@loicmathieu
Copy link
Contributor Author

@rsvoboda accessors rewritting as exist for Hibernate with Panache has been implemented, so now person.name was rewritten to person.getName() inside the Panache processor and the test fail.

@rsvoboda
Copy link
Member

@loicmathieu
Copy link
Contributor Author

@evanchooly the just merged field accessor rewritting you implemented for MongoDB with Panache can cause some bugs on existing code where getters/setters exists but developer still use the field directly. This was the case on the quickstart.

As @rsvoboda suggested, maybe it'll be a good idea to add a note about it inside the migration guide for 1.11

@evanchooly
Copy link
Member

wouldn't a simple rebuild fix this? I can certainly add a note to that effect but I'm a little surprised it broke a test since rebuilding them should have updated the bytecode accordingly. What did the breakage look like?

@loicmathieu
Copy link
Contributor Author

There was a lowercase on the getter, previously it was not used, now it is.

@evanchooly
Copy link
Member

oh! i see. That entity had hand crafted a getter which was bypassed with field access. Got it. That was the missing piece for me.

@loicmathieu loicmathieu deleted the fix/mongodb-test branch June 17, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants