Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform token serialization in C++ #2218

Closed
koheiw opened this issue Mar 19, 2023 · 3 comments
Closed

Perform token serialization in C++ #2218

koheiw opened this issue Mar 19, 2023 · 3 comments
Assignees
@koheiw

Comments

@koheiw
Copy link
Collaborator

koheiw commented Mar 19, 2023 •
edited
Loading

It is tested on the dev-serialize branch.
@koheiw koheiw self-assigned this Mar 19, 2023
@koheiw koheiw changed the title Perform token serizization in C++ Perform token serializatiaon in C++ Mar 20, 2023
@koheiw koheiw changed the title Perform token serializatiaon in C++ Perform token serialization in C++ Mar 21, 2023
koheiw added a commit that referenced this issue Mar 21, 2023
@koheiw
For #2218
67bff3c 
- Add cpp_serialize_new() and cpp_serialize_add()
- Return tokens_xptr
@koheiw koheiw mentioned this issue Mar 21, 2023
Merged
@kbenoit
Copy link
Collaborator

kbenoit commented Apr 3, 2023

Does this issue require xpointers or can it be merged into v3?

@koheiw
Copy link
Collaborator Author

koheiw commented Apr 3, 2023

I don't think it will make it faster because of the overhead in copying objects between C++ and R. The C++ header is also very different in v4 .

@kbenoit
Copy link
Collaborator

kbenoit commented Apr 3, 2023

It's already merged into master which is as of today, in v3, so we can close this issue.

@kbenoit kbenoit closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koheiw koheiw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbenoit @koheiw