Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcm() does not check ... #2103

Closed
kbenoit opened this issue Apr 12, 2021 · 0 comments · Fixed by #2235
Closed

fcm() does not check ... #2103

kbenoit opened this issue Apr 12, 2021 · 0 comments · Fixed by #2235

Comments

@kbenoit
Copy link
Collaborator

kbenoit commented Apr 12, 2021

We forgot check_dots(...)...

> toks <- tokens(c("A D A C E A D"))
> fcm(toks, not_an_argument = TRUE)
Feature co-occurrence matrix of: 4 by 4 features.
        features
features A D C E
       A 3 6 3 3
       D 0 1 2 2
       C 0 0 0 1
       E 0 0 0 0
kbenoit pushed a commit that referenced this issue Apr 4, 2023
Fix #2103
0dcf72f 
We really should test this for every function, the same way we perform package-wide tests in `test-default-methods.R`.
@kbenoit kbenoit mentioned this issue Apr 4, 2023
Merged
kbenoit added a commit that referenced this issue Apr 4, 2023
@kbenoit
Merge pull request #2235 from quanteda/fix-2103
ca7edf6 
Fix #2103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2103 quanteda/quanteda
1 participant
@kbenoit