Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximize windows that wanted to maximize #4426

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yonnji
Copy link
Contributor

@Yonnji Yonnji commented Aug 30, 2023

This is for the gnome apps that have maximize buttons in the header bar. It also tracks the state of the window and updates button state when maximize is triggered by qtile itself.

2023-08-30_16-06

2023-08-30_16-07

Copy link
Member

@ramnes ramnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you eventually add a note in CHANGELOG and a test?

@Yonnji
Copy link
Contributor Author

Yonnji commented Sep 1, 2023

Can you eventually add a note in CHANGELOG and a test?

Added a note and a test.

@ramnes
Copy link
Member

ramnes commented Sep 1, 2023

CI seems to fail but it's probably unrelated, can you rebase on top of master? I tried to do it myself but I'm not allowed to force push your branch. :(

@Yonnji
Copy link
Contributor Author

Yonnji commented Sep 1, 2023

can you rebase on top of master?

Ok. I think I did it.

@jwijenbergh
Copy link
Contributor

@Yonnji can you rebase?

@jwijenbergh
Copy link
Contributor

Sorry can you rebase again?

@jwijenbergh
Copy link
Contributor

jwijenbergh commented Sep 25, 2023

Hi! It seems like some commits from the master branch made its way here. Can you do a git pull origin && git rebase "origin/master". Where origin is the qtile git remote

Or I think there is a button somewhere where you allow maintainers to push and I will rebase it

@ramnes
Copy link
Member

ramnes commented Sep 26, 2023

Did you close that one by accident @Yonnji? :)

@Yonnji Yonnji reopened this Sep 26, 2023
@Yonnji
Copy link
Contributor Author

Yonnji commented Sep 26, 2023

Did you close that one by accident @Yonnji? :)

Yes, I did messed up with rebase, so I made a new commit.

Copy link

github-actions bot commented Mar 9, 2024

This PR is stale because it has been open 90 days with no activity. Remove the status: stale label or comment, or this will be closed in 30 days.

@elParaguayo
Copy link
Member

@ramnes @jwijenbergh presumably we still want this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants