Skip to content

Commit

Permalink
CMake: Remove the dysfunctional -testcocoon configure option
Browse files Browse the repository at this point in the history
TestCocoon is not maintained anymore, and the -testcocoon configure
option of Qt didn't do anything useful since Qt 6.0.0.

Remove the option. It's possible to create an instrumented build by
using dedicated CMake toolchain files as described in the documentation
of Squish Coco (TestCocoon's replacement).

Fixes: QTBUG-88316
Change-Id: I8a565cdd288aca9208f48138d2b663802cc0de90
Reviewed-by: Alexey Edelev <[email protected]>
  • Loading branch information
jobor committed Jun 16, 2023
1 parent c5b0fa6 commit 4d1525b
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion cmake/configure-cmake-mapping.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ The following table describes the mapping of configure options to CMake argument
| -appstore-compliant | -DFEATURE_appstore_compliant=ON | |
| -qtnamespace <name> | -DQT_NAMESPACE=<name> | |
| -qtlibinfix <infix> | -DQT_LIBINFIX=<infix> | |
| -testcocoon | | |
| -gcov | | |
| -trace [backend] | -DINPUT_trace=yes or -DINPUT_trace=<backend> | |
| | or -DFEATURE_<backend> | |
Expand Down
1 change: 0 additions & 1 deletion config_help.txt
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ Build options:
-qtnamespace <name> .. Wrap all Qt library code in 'namespace <name> {...}'.
-qtlibinfix <infix> .. Rename all libQt6*.so to libQt6*<infix>.so.

-testcocoon .......... Instrument with the TestCocoon code coverage tool [no]
-gcov ................ Instrument with the GCov code coverage tool [no]

-trace [backend] ..... Enable instrumentation with tracepoints.
Expand Down
5 changes: 0 additions & 5 deletions configure.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -568,11 +568,6 @@ qt_feature("largefile"
)
qt_feature_definition("largefile" "QT_LARGEFILE_SUPPORT" VALUE "64")
qt_feature_config("largefile" QMAKE_PRIVATE_CONFIG)
qt_feature("testcocoon"
LABEL "Testcocoon support"
AUTODETECT OFF
)
qt_feature_config("testcocoon" QMAKE_PUBLIC_CONFIG)
qt_feature("sanitize_address"
LABEL "Addresses"
AUTODETECT OFF
Expand Down
1 change: 0 additions & 1 deletion qt_cmdline.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ qt_commandline_option(static-runtime TYPE boolean NAME static_runtime)
qt_commandline_option(strip TYPE boolean)
qt_commandline_option(syncqt TYPE boolean)
qt_commandline_option(sysroot TYPE string)
qt_commandline_option(testcocoon TYPE boolean)
qt_commandline_option(use-gold-linker TYPE boolean NAME use_gold_linker_alias)
qt_commandline_option(warnings-are-errors TYPE boolean NAME warnings_are_errors)
qt_commandline_option(Werror TYPE boolean NAME warnings_are_errors)
Expand Down

0 comments on commit 4d1525b

Please sign in to comment.