-
-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 new LED effect animations #9827
Conversation
This is my first PR ever so if I've done something wrong please advise me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the docs page, as well?
https://github.com/qmk/qmk_firmware/blob/master/docs/feature_rgb_matrix.md#rgb-matrix-effects-idrgb-matrix-effects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Forgive me, I'm still new to Github, is there anything else I need to do? I think I committed the suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from what fauxpark has indicated, it looks good.
Thank you for your contribution! |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Erovia <[email protected]>
Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Erovia <[email protected]>
Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Erovia <[email protected]>
Description
3 new LED effect animations based on subtly shifting the hue over time and then returning to the starting hue without a noticeable break.
3 files are added, hue_breathing_anim.h; hue_pendulum_anim.h; and hue_wave_anim.h;
1 file is changed, rgb_matrix_effects.inc;
All 3 rely on the same variable name, huedelta, to determine what I like to think of as the shift in hue. Each *anim.h file has the value set statically.
Tested on a Massdrop/Alt
Types of Changes
Checklist