Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 new LED effect animations #9827

Merged
merged 12 commits into from
Apr 3, 2021
Merged

3 new LED effect animations #9827

merged 12 commits into from
Apr 3, 2021

Conversation

TurtleHunter
Copy link

@TurtleHunter TurtleHunter commented Jul 25, 2020

Description

3 new LED effect animations based on subtly shifting the hue over time and then returning to the starting hue without a noticeable break.

  • Hue Breathing - All LED's shift hue at the same time.
  • Hue Pendulum - Hue shift changes in a wave to the right before reversing direction to the left.
  • Hue Wave - Hue shift changes in a wave to the right continuously.

3 files are added, hue_breathing_anim.h; hue_pendulum_anim.h; and hue_wave_anim.h;
1 file is changed, rgb_matrix_effects.inc;
All 3 rely on the same variable name, huedelta, to determine what I like to think of as the shift in hue. Each *anim.h file has the value set statically.

Tested on a Massdrop/Alt

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@TurtleHunter
Copy link
Author

This is my first PR ever so if I've done something wrong please advise me.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quantum/rgb_matrix_animations/rgb_matrix_effects.inc Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 26, 2020 16:30
@zvecr zvecr added the core label Jul 26, 2020
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format

quantum/rgb_matrix_animations/hue_breathing_anim.h Outdated Show resolved Hide resolved
quantum/rgb_matrix_animations/hue_pendulum_anim.h Outdated Show resolved Hide resolved
quantum/rgb_matrix_animations/hue_wave_anim.h Outdated Show resolved Hide resolved
@TurtleHunter
Copy link
Author

Forgive me, I'm still new to Github, is there anything else I need to do? I think I committed the suggested changes

docs/feature_rgb_matrix.md Outdated Show resolved Hide resolved
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from what fauxpark has indicated, it looks good.

@stale
Copy link

stale bot commented Sep 14, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna requested a review from a team December 17, 2020 04:17
@Erovia Erovia merged commit a3cd129 into qmk:master Apr 3, 2021
@Erovia Erovia mentioned this pull request Apr 3, 2021
14 tasks
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Erovia <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Erovia <[email protected]>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Erovia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants