Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch my Chrome OS media keys workaround from mouse keys to NKRO #9790

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Switch my Chrome OS media keys workaround from mouse keys to NKRO #9790

merged 3 commits into from
Jul 23, 2020

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Jul 21, 2020

Description

On further investigation, it seems that Chrome OS isn't processing media keys unless the USB endpoint with the consumer and system control devices also contains a keyboard or mouse device. Mouse keys aren't useful to me, and they actually seem to cause a Windows bug instead (#8323), so I'm switching to NKRO. This functions as an equivalent workaround for Chrome OS, and is also at least theoretically useful to me.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keymap label Jul 21, 2020
@zvecr zvecr requested a review from a team July 21, 2020 22:23
keyboards/crkbd/keymaps/bcat/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/bcat/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr merged commit d699fd1 into qmk:master Jul 23, 2020
@zvecr
Copy link
Member

zvecr commented Jul 23, 2020

Thanks!

@bcat bcat deleted the bcat_endpoints branch July 23, 2020 17:15
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
…mk#9790)

* Switch Chrome OS mouse keys workaround to NKRO

* Add NKRO toggle to keymaps

* USE NK_TOGG keycode instead of defining my own
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
…mk#9790)

* Switch Chrome OS mouse keys workaround to NKRO

* Add NKRO toggle to keymaps

* USE NK_TOGG keycode instead of defining my own
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants