Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keymap] curly quotes #9662

Merged
merged 6 commits into from
Jul 10, 2020
Merged

[keymap] curly quotes #9662

merged 6 commits into from
Jul 10, 2020

Conversation

callum-oakley
Copy link
Contributor

Just upstreaming some keymap changes. :)

fauxpark
fauxpark requested changes Jul 6, 2020
View reviewed changes
keyboards/planck/keymaps/callum/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team July 6, 2020 09:04
@fauxpark fauxpark added the keymap label Jul 6, 2020
Erovia
Erovia reviewed Jul 8, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the config.h if you don't need it.

keyboards/planck/keymaps/callum/readme.md Outdated Show resolved Hide resolved
@Erovia Erovia requested review from a team and fauxpark July 8, 2020 18:36
@Erovia Erovia requested a review from a team July 9, 2020 19:26
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit c50009d into qmk:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@callum-oakley @fauxpark @Erovia @zvecr