Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIA Support: DO60 #9622

Merged
merged 5 commits into from
Jul 24, 2020
Merged

VIA Support: DO60 #9622

merged 5 commits into from
Jul 24, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Jul 2, 2020 •
edited
Loading

Description

Added VIA enabled keymap along with a few refactors

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added enhancement via Adds via keymap and/or updates keyboard for via support labels Jul 2, 2020
zvecr
zvecr requested changes Jul 3, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While changing keyboards/do60/do60.h, can we do something with the following block

inline void setdefaultrgb(void){ rgblight_sethsv(100,100,100); }

rgblight_sethsv_noeeprom as a minimum, but maybe the eeprom reset stuff?

@zvecr zvecr requested a review from a team July 3, 2020 22:59
drashna
drashna approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna merged commit 2cebac6 into qmk:master Jul 24, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@mechmerlin @nicocesar
[Keyboard] VIA Support: DO60 (qmk#9622)
fe24e15 
* fix up that vendor ID

* add a VIA enabled keymap

* use pragma once

* clean up indicator leds code

* remove unused header
@mechmerlin mechmerlin deleted the feature/do60_via branch January 26, 2021 14:52
@dunk2k dunk2k mentioned this pull request Apr 6, 2024
Closed
7 tasks
@dunk2k dunk2k mentioned this pull request Apr 17, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mechmerlin @drashna @fauxpark @zvecr