Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext65rev2 - New Keyboard #9482

Merged
merged 35 commits into from
Aug 13, 2020
Merged

Ext65rev2 - New Keyboard #9482

merged 35 commits into from
Aug 13, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Jun 20, 2020

Description

Add Ext65Rev2 PCB since #9414 was merged.
Refactor Rev1 and Rev2 into EXT65

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • New keyboard addition

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Xelus22 Xelus22 mentioned this pull request Jun 20, 2020
6 tasks
@zvecr zvecr added the keyboard label Jun 21, 2020
@Xelus22 Xelus22 requested a review from zvecr July 1, 2020 00:00
@drashna drashna requested a review from a team July 5, 2020 01:48
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be moved under the existing ext65 directory as a /rev2?

keyboards/aeboards/ext65rev2/ext65rev2.c Outdated Show resolved Hide resolved
keyboards/aeboards/ext65rev2/ext65rev2.c Outdated Show resolved Hide resolved
keyboards/aeboards/ext65rev2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/aeboards/ext65rev2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/aeboards/ext65rev2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aeboards/ext65rev2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aeboards/ext65/rev2/config.h Outdated Show resolved Hide resolved
keyboards/aeboards/ext65/rev2/rules.mk Outdated Show resolved Hide resolved
@Xelus22 Xelus22 changed the base branch from master to develop August 5, 2020 07:17
@drashna drashna requested a review from a team August 7, 2020 03:02
@noroadsleft
Copy link
Member

I don't know why the base branch is set to develop here. 😕

@Xelus22
Copy link
Contributor Author

Xelus22 commented Aug 8, 2020

Zvecr said it was a breaking change @noroadsleft

@noroadsleft
Copy link
Member

Zvecr said it was a breaking change

looks

Ah, it was at that time, but it's not anymore.

@noroadsleft noroadsleft removed the breaking_change Changes that need to wait for a version increment label Aug 8, 2020
@noroadsleft noroadsleft changed the base branch from develop to master August 8, 2020 07:34
keyboards/aeboards/ext65/rev2/rules.mk Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit c957eed into qmk:master Aug 13, 2020
@noroadsleft
Copy link
Member

Thanks!

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
* ext65rev2 initial

* open drain change and config

* pwm

* pwm streams

* spi

* ws2812 spi

* oled

* enable sleep

* keymap and dissable oled

* readd oleds

* nooled

* led_update_kb revised

* update and remove board specific files and add to ext65rev2.c

* Update OLED usb status

* Update  keyboards led state

* Layer state set kb

* Return state

* Update  keyboards led state

* Update OLED usb status

* merge master and merge rev folders

* add readme

* move board_init to only if OLED is enabled

* update readme

* update rules.mk

* Remove OLED from rules.mk

* Update config.h

* show AEBoards

* Update keyboards/aeboards/ext65/rev2/rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants