Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for user song lists #9281

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Allow for user song lists #9281

merged 1 commit into from
Jul 16, 2020

Conversation

drashna
Copy link
Member

@drashna drashna commented Jun 3, 2020

Description

Allows for user song lists to be added, but keeps them out of the repo (for legal reasons).

Additionally, defines the removed songs weakly, so people can use them without issue.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team June 3, 2020 04:47
@drashna drashna changed the base branch from master to develop June 5, 2020 08:58
@drashna drashna changed the base branch from develop to master June 5, 2020 08:58
@tzarc tzarc requested a review from a team June 9, 2020 20:33
@drashna drashna marked this pull request as ready for review June 10, 2020 18:09
@tzarc tzarc merged commit f11437a into qmk:master Jul 16, 2020
@drashna drashna deleted the audio/custom_songs branch July 17, 2020 21:59
drashna added a commit to zsa/qmk_firmware that referenced this pull request Aug 9, 2020
@drashna
Allow for user song list (qmk#9281)
281a94c
@robbiet480
Copy link

@drashna Where should the user_song_list.h file be placed? Doesn't seem to be picked up from my user keymap

@drashna
Copy link
Member Author

drashna commented Sep 9, 2020

Basically anywhere. Make sure that your repo is up to date, and that you have it named exactly as user_song_list.h

I have mine stored in userspace folder, but have verified that it works in a keyboard/keymap folder, and in layouts.

robbiet480 pushed a commit to robbiet480/qmk_firmware that referenced this pull request Sep 9, 2020
@drashna @robbiet480
Allow for user song list (qmk#9281)
449fc8d
@robbiet480
Copy link

Doh! Forgot to cherry pick the commit into the ZSA fork, thanks for the tip & quick response!

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Allow for user song list (qmk#9281)
6b06b32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drashna @robbiet480 @tzarc