CLI: fix json2c subcommand and add/fix tests
#9206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skullydazed
reviewed
May 26, 2020
Co-authored-by: Zach White <[email protected]>
skullydazed
approved these changes
May 26, 2020
nesth
pushed a commit
to nesth/qmk_firmware
that referenced
this pull request
Jun 11, 2020
* upstream/master: (800 commits) Fix crkbd slave matrix print to require debug_matrix (qmk#9217) Keyboards/zsa updates (qmk#9214) Community layout support for KBDpad Mk.I (qmk#9220) Fix projectkb/alice LED indicator (qmk#9226) RSTHD keymap for Minidox (qmk#9178) Fix running qmk info without any arguments (qmk#9218) [Keymap] Update yttyx Planck keymap (qmk#9191) Documentation for keymap_extras (qmk#9194) Adding TGR Tris/Tris CE Numpad (qmk#9139) ISSI driver compile error fix (qmk#9169) Fix the path for generated keymaps (qmk#9213) Fix compiling json files (qmk#9210) [CLI] Add a subcommand for getting information about a keyboard (qmk#8666) [Keymap] Contributing Home-Row-Centric-Mousekey Layout (qmk#9195) CLI: fix `json2c` subcommand and add/fix tests (qmk#9206) [Keymap] Ported ok60 to via (qmk#9179) [Docs] Japanese translation of docs/feature_pointing_device.md (qmk#8993) [Keymap] Niu keymap and README update (qmk#9190) [Keyboard] Add Key 65 by Fox Lab (qmk#9116) [Keymap] update helix/rev2:yshrsmz keymap (qmk#9047) ...
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
Co-authored-by: Zach White <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
Co-authored-by: Zach White <[email protected]>
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 9, 2020
Co-authored-by: Zach White <[email protected]>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
Co-authored-by: Zach White <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Co-authored-by: Zach White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This went under the radar for too long (since the Python 3.6 move) due to not having any test cases.
So now we have for this subcommand.
Types of Changes
Issues Fixed or Closed by This PR
Checklist