Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin 26, 27, 28, 30 keys compatibility #9136

Merged
merged 2 commits into from
May 19, 2020
Merged

Conversation

stevexyz
Copy link
Contributor

Description

This update of the Gherkin keymap make the original 28 keys design compatible to a 26 "pure alpha" one, as well as 27 (alpha+space) and 30 keys (all the Gherkin switches installed).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

No issues detected to close

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 19, 2020 11:40
@drashna drashna added the keymap label May 19, 2020
@zvecr zvecr merged commit 6c2008c into qmk:master May 19, 2020
@zvecr
Copy link
Member

zvecr commented May 19, 2020

Thanks!

binjeh added a commit to binjeh/qmk_firmware that referenced this pull request May 20, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (606 commits)
  Reintegrate previous docker docs (qmk#9084)
  Add VIA Keymap to Liminal Directory (qmk#8965)
  Adding Chimera Ortho Plus (qmk#9093)
  Added custom keymap with french mac layout. (qmk#9115)
  Art userspace (qmk#9068)
  Add Via support to the YMD09 (qmk#9108)
  Candybar: VIA support for lefty and righty (qmk#9066)
  Gherkin 26, 27, 28, 30 keys compatibility (qmk#9136)
  MSYS2 install: bodge out avrdude package installation for USBaspLoader
  Disable Mousekey Command interface when Constant speed is enabled (qmk#7017)
  [Keyboard] Add Bakeneko 80 keyboard (qmk#9118)
  [Keymap] Add Via support to ALPS64 (qmk#9041)
  [Keyboard] add kbdfans/maja rgb keyboard (qmk#9114)
  [Keyboard] Add NumDiscipline Keyboard - Modified Version of Discipline With Numpad (qmk#9112)
  Streamline the macos install process
  [Docs] Japanese translation of docs/feature_led_matrix.md (qmk#8991)
  [Docs] Japanese translation of docs/feature_layouts.md (qmk#8949)
  [Docs] Japanese translation of docs/feature_thermal_printer.md (qmk#9034)
  [Docs] Japanese translation of docs/feature_velocikey.md (qmk#9035)
  [Docs] Japanese translation of docs/feature_leader_key.md (qmk#8950)
  ...
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* Gherkin 26, 27, 28, 30 compatibility

* Update readme.md

Co-authored-by: stevexyz <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Gherkin 26, 27, 28, 30 compatibility

* Update readme.md

Co-authored-by: stevexyz <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Gherkin 26, 27, 28, 30 compatibility

* Update readme.md

Co-authored-by: stevexyz <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* Gherkin 26, 27, 28, 30 compatibility

* Update readme.md

Co-authored-by: stevexyz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants