Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nt660 PCB #9042

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Add nt660 PCB #9042

merged 3 commits into from
Jun 9, 2020

Conversation

evyd13
Copy link
Contributor

@evyd13 evyd13 commented May 7, 2020

Description

Adds the nt660 PCB to QMK. Has my keymap as well as a default and a VIA enabled keymap. This PCB is a direct replacement for the Leopold FC660m.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@evyd13
Copy link
Contributor Author

evyd13 commented May 7, 2020

It's also known as the mt660, but due to there already being a mt980 in qmk I decided to rename it.

@zvecr zvecr added the keyboard label May 15, 2020
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly different orientation of caps on the bottom row, but nothing that stops the 66 community layouts from being compatible.

keyboards/maartenwut/nt660/info.json Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/info.json Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/nt660.c Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/nt660.h Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/nt660.h Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/rules.mk Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/nt660.c Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team May 15, 2020 17:02
keyboards/maartenwut/nt660/config.h Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/keymaps/maartenwut/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team May 19, 2020 10:29
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
keyboards/maartenwut/nt660/readme.md Outdated Show resolved Hide resolved
keyboards/maartenwut/nt660/info.json Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 86812f2 into qmk:master Jun 9, 2020
@noroadsleft
Copy link
Member

Thanks!

@evyd13 evyd13 deleted the nt660 branch June 9, 2020 20:20
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Upload nt660 files

* Apply suggestions from code review

* Apply suggestions from code review
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Upload nt660 files

* Apply suggestions from code review

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants